← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~akretion-team/banking-addons/61-sepa-direct-debit into lp:banking-addons/6.1

 

Review: Needs Fixing

It seems this still needs updating with the results from the review of the 7.0 branch https://code.launchpad.net/~akretion-team/banking-addons/70-sepa-trf-dd-updates/+merge/200019. Otherwise, looks good obviously.

There are some seemingly unrelated changes in account_banking/account_banking.py, but they all look like improvements to me. The changes to exception handling in this file are probably trying to fix the same issue that this branch addresses: https://code.launchpad.net/~therp-nl/banking-addons/6.1-no_unnecessary_raise/+merge/205647.
-- 
https://code.launchpad.net/~akretion-team/banking-addons/61-sepa-direct-debit/+merge/200020
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/6.1.


References