← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~banking-addons-drivers/banking-addons/direct-debit-refactoring-fosdem into lp:banking-addons

 

Review: Needs Fixing

Thanks, looks really good.

About the auto_install values: I think the one in line 103 was a copy/paste error when account_banking_payment_export was split off from account_banking_payment. However, the one in account_banking_payment was always there on purpose as it made sense to install the payment part of account_banking when both account_banking and account_payment were installed. I think it still makes sense with the new dependencies account_banking and account_banking_payment_export, so I'd like to keep the one in line 36.


-- 
https://code.launchpad.net/~banking-addons-drivers/banking-addons/direct-debit-refactoring-fosdem/+merge/204391
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.


References