banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-related-balance-check into lp:banking-addons/bank-statement-reconcile-7.0

To: Leonardo Pistone - camptocamp <leonardo.pistone@xxxxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Fri, 07 Mar 2014 09:12:27 -0000
In-reply-to: <20140306163822.1034.42800.launchpad@ackee.canonical.com>
Reply-to: mp+209723@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Hi, Leonardo,

Curious, I don't know about that behaviour. Don't you think then that it's better to rename self to profile_obj or something similar to avoid bad interpretations?

I also see cleaner the lamba expression, but this is a matter of taste, so I'm not going to block the MP for this reason.

Regards.
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-related-balance-check/+merge/209723
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-fix-related-balance-check into lp:banking-addons/bank-statement-reconcile-7.0
From: Leonardo Pistone - camptocamp, 2014-03-06