← Back to team overview

banking-addons-team team mailing list archive

[Merge] lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing into lp:banking-addons/bank-statement-reconcile-7.0

 

Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing into lp:banking-addons/bank-statement-reconcile-7.0.

Commit message:
[IMP] account_statement_base_import: Allow to use profile data for customizing parsing

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing/+merge/214379

Simple improvement on the account_statement_base_import module to have profile data on parse method to use it to customize parsing with, for example, a parameter introduced on profiles.

There is no need to do it anything more, because parse method already contains *args and **kwargs. You can access profile data with args[0] in parse method.
-- 
https://code.launchpad.net/~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing/+merge/214379
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing into lp:banking-addons/bank-statement-reconcile-7.0.
=== modified file 'account_statement_base_import/statement.py'
--- account_statement_base_import/statement.py	2014-04-01 15:54:00 +0000
+++ account_statement_base_import/statement.py	2014-04-05 09:27:35 +0000
@@ -166,7 +166,7 @@
         prof = prof_obj.browse(cr, uid, profile_id, context=context)
 
         parser = new_bank_statement_parser(prof.import_type, ftype=ftype)
-        result_row_list = parser.parse(file_stream)
+        result_row_list = parser.parse(file_stream, prof)
         # Check all key are present in account.bank.statement.line!!
         if not result_row_list:
             raise osv.except_osv(_("Nothing to import"),


Follow ups