banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing into lp:banking-addons/bank-statement-reconcile-7.0

To: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Fri, 02 May 2014 15:09:15 -0000
In-reply-to: <20140405092822.8743.48494.launchpad@ackee.canonical.com>
Reply-to: mp+214379@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Next time someone review this module, he will wander why prof is passed to parser and why it is unused.

You should at least add a comment if you don't want it to be removed. Otherwise you should create a hook.
-- 
https://code.launchpad.net/~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing/+merge/214379
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~pedro.baeza/banking-addons/7.0-bank-statement-reconcile-prof_parsing into lp:banking-addons/bank-statement-reconcile-7.0
From: Pedro Manuel Baeza, 2014-04-05