banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-improve-acc-number-completion into lp:banking-addons/bank-statement-reconcile-7.0

To: "Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Fri, 02 May 2014 10:36:19 -0000
In-reply-to: <20140424110324.29720.23973.launchpad@ackee.canonical.com>
Reply-to: mp+202861@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

res_partner_bank.py

Missing encoding definition in res_partner_bank.py

ll.49-51 have indentation issues

About SQL querry isn't it an issue of how are saved account number in database?

Maybe we should ensure data is clean instead of doing special querries.
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-improve-acc-number-completion/+merge/202861
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

[Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-improve-acc-number-completion into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2014-04-24