banking-addons-team team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Public bug reported:

Hi,


In the account_statement_one_move, we have a trouble. I had unfortunately no time to investigate more, but wanted to warn people about what I saw:

 * If you use the group move option on a profile, then it didn't call
super(account_bank_statement, self).create_move_from_st_line() => so if
you have any other module that need to do something here, it won't !

 * I sometimes had one proper move generated, and some time a variable
number of moves. I didn't figured out why or in which contexte, sorry.

 * It seems that this module isn't compatible with
account_default_draft_move nor with account_constraints (thought some
work has been done to make it work with the last one by passing
"context['from_parent_object'] = True", but this is a work around,
because what we want is to call super in ANY case)

 * The design of the whole bank_statemnet is not made to support this
use case, looking in the "create_move_from_st_line" function, you will
see this. We call this method for each statement line and compute the
bank and counter part account for every of them. Making one move will
imply to change that logic everywhere. Remember that this method is part
of the addons :(

I tried to figure those problem out in that MP here but didn't succeed
and found no clean solution :https://code.launchpad.net/~camptocamp
/banking-addons/bank-statement-reconcile-7.0-one-move-fix-
jge/+merge/209867

I have no real idea on how to solve this, any suggestion is welcome, but
for know, I want to suggest marking this module
"account_statement_one_move" as installable = False to avoid people use
it.


Regards,

** Affects: banking-addons
     Importance: Undecided
         Status: New

** Branch linked: lp:~camptocamp/banking-addons/bank-statement-
reconcile-7.0-one-move-fix-jge

-- 
You received this bug notification because you are a member of Banking
Addons Core Editors, which is subscribed to Banking Addons.
https://bugs.launchpad.net/bugs/1317064

Title:
  Design trouble on account_statement_one_move, avoiding the call to
  super()

Status in OpenERP Banking Addons:
  New

Bug description:
  Hi,

  
  In the account_statement_one_move, we have a trouble. I had unfortunately no time to investigate more, but wanted to warn people about what I saw:

   * If you use the group move option on a profile, then it didn't call
  super(account_bank_statement, self).create_move_from_st_line() => so
  if you have any other module that need to do something here, it won't
  !

   * I sometimes had one proper move generated, and some time a variable
  number of moves. I didn't figured out why or in which contexte, sorry.

   * It seems that this module isn't compatible with
  account_default_draft_move nor with account_constraints (thought some
  work has been done to make it work with the last one by passing
  "context['from_parent_object'] = True", but this is a work around,
  because what we want is to call super in ANY case)

   * The design of the whole bank_statemnet is not made to support this
  use case, looking in the "create_move_from_st_line" function, you will
  see this. We call this method for each statement line and compute the
  bank and counter part account for every of them. Making one move will
  imply to change that logic everywhere. Remember that this method is
  part of the addons :(

  I tried to figure those problem out in that MP here but didn't succeed
  and found no clean solution :https://code.launchpad.net/~camptocamp
  /banking-addons/bank-statement-reconcile-7.0-one-move-fix-
  jge/+merge/209867

  I have no real idea on how to solve this, any suggestion is welcome,
  but for know, I want to suggest marking this module
  "account_statement_one_move" as installable = False to avoid people
  use it.

  
  Regards,

To manage notifications about this bug go to:
https://bugs.launchpad.net/banking-addons/+bug/1317064/+subscriptions