brewtarget-devs team mailing list archive

[Philip Lee <rocketman768@xxxxxxxxx>]

I think the reason they are different is that displayFG used to display
apparent FG as read by a refractometer instead of the true FG. This is why
it includes the OG as a parameter. It seems like the OG is not considered
anymore?


On Mon, Sep 1, 2014 at 2:29 PM, mik firestone <mikfire@xxxxxxxxx> wrote:

> Based on the comments, I am guessing these two methods were once
> significantly different.
>
> My reading is that now the bodies of the two methods are almost identical.
> displayFG has an extra check to make sure the supplied OG is reasonable.
>
> I am currently in the middle of a huge refactoring. The refactoring should
> make things  a lot easier to add later. It would make things easier for
> this effort if I could either collapse the two methods into one, or if I
> could simply fold it all into displayAmount().
>
> Is there any significant difference between these two methods, and is
> there any reason I shouldn't merge them?
>
> Thanks,
> Mik
>
> --
> In a world of ninja v. pirate, I pilot a Gundam
>
> --
> Mailing list: https://launchpad.net/~brewtarget-devs
> Post to     : brewtarget-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~brewtarget-devs
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Philip G. Lee
www.linkedin.com/in/philipgreggorylee