← Back to team overview

brewtarget-devs team mailing list archive

Re: Mergefest

 

Thanks Mik! The one I mentioned may have been a bad manual merge on my part.

On Sat, Jan 31, 2015 at 8:54 PM, mik firestone <mikfire@xxxxxxxxx> wrote:

> and both fixed with merge request 116.
>
> Mik
>
> On Sat, Jan 31, 2015 at 4:22 PM, mik firestone <mikfire@xxxxxxxxx> wrote:
>
>> No, but that is my code. I will see what the malfunction is there.
>>
>> I am getting a warning out of BtLineEdit.h saying:
>>   warning: in C++03 a class-key must be used when declaring a friend
>> and it is specifically whining about BtMixedEdit.
>>
>> Which is my code too :)
>>
>> Mik
>>
>>
>> On Sat, Jan 31, 2015 at 4:04 PM, Philip Lee <rocketman768@xxxxxxxxx>
>> wrote:
>>
>>> Was that the action group warning?
>>>
>>> brewtarget.cpp:1419:18: warning: unused variable ‘qsgrp’
>>> [-Wunused-variable]
>>>     QActionGroup* qsgrp = new QActionGroup(menu);
>>>
>>> If anybody recognizes this code, have a look and kindly put up an MR to
>>> silence the compiler.
>>>
>>> On Sat, Jan 31, 2015 at 2:51 PM, mik firestone <mikfire@xxxxxxxxx>
>>> wrote:
>>>
>>>> Outside of some pedantic warnings (one warning, repeated many times) it
>>>> seems to compile, run and not sigsegv.
>>>>
>>>> I am somewhat surprised. :)
>>>>
>>>> Mik
>>>>
>>>>
>>>> On Sat, Jan 31, 2015 at 3:25 PM, Philip Lee <rocketman768@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> ...and toes if you can cross them :)
>>>>>
>>>>> On Sat, Jan 31, 2015 at 2:23 PM, Maxime Lavigne <
>>>>> maxime.lavigne@xxxxxxxxxxxxxx> wrote:
>>>>>
>>>>>> Hi hi Sir.
>>>>>>
>>>>>> Congrats, are we suppose to cross our finger for the first build,
>>>>>> haha?
>>>>>>
>>>>>> malavv
>>>>>>
>>>>>> On 31 January 2015 at 15:22, Philip Lee <rocketman768@xxxxxxxxx>
>>>>>> wrote:
>>>>>>
>>>>>>> Mergefest complete. Please refetch and rebuild.
>>>>>>>
>>>>>>> On Sat, Jan 31, 2015 at 12:15 PM, mik firestone <mikfire@xxxxxxxxx>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> And may St. Stevens intercede on my behalf...
>>>>>>>>
>>>>>>>> On Sat, Jan 31, 2015 at 11:57 AM, Philip Lee <
>>>>>>>> rocketman768@xxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>>> All,
>>>>>>>>>
>>>>>>>>> I am spending today merging the staged MRs. Does anyone have any
>>>>>>>>> qualms about MR99?
>>>>>>>>>
>>>>>>>>> https://gitorious.org/brewtarget/brewtarget/merge_requests/99
>>>>>>>>>
>>>>>>>>> Speak now or forever hold your peace...
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dr. Philip G. Lee
>>>>>>>>> www.linkedin.com/in/philipgreggorylee
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Mailing list: https://launchpad.net/~brewtarget-devs
>>>>>>>>> Post to     : brewtarget-devs@xxxxxxxxxxxxxxxxxxx
>>>>>>>>> Unsubscribe : https://launchpad.net/~brewtarget-devs
>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> In a world of ninja v. pirate, I pilot a Gundam
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dr. Philip G. Lee
>>>>>>> www.linkedin.com/in/philipgreggorylee
>>>>>>>
>>>>>>> --
>>>>>>> Mailing list: https://launchpad.net/~brewtarget-devs
>>>>>>> Post to     : brewtarget-devs@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~brewtarget-devs
>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dr. Philip G. Lee
>>>>> www.linkedin.com/in/philipgreggorylee
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> In a world of ninja v. pirate, I pilot a Gundam
>>>>
>>>
>>>
>>>
>>> --
>>> Dr. Philip G. Lee
>>> www.linkedin.com/in/philipgreggorylee
>>>
>>
>>
>>
>> --
>> In a world of ninja v. pirate, I pilot a Gundam
>>
>
>
>
> --
> In a world of ninja v. pirate, I pilot a Gundam
>



-- 
Dr. Philip G. Lee
www.linkedin.com/in/philipgreggorylee

References