bzr-eclipse team mailing list archive

[Piotr Piastucki <piastucki@xxxxxxxxx>]

Hi,

Thank you very much for your feedback. Please see my comments below.

> Hi Piotr, Here are a few more questions/issues I had with the 1.3
> candidates.
>
> + The change to the new project wizard, allowing selection of
>   type for the created project is good.  However,
>    - Name should pass through to the new project, I find myself
>      typing in the same name again.
AFAIK there is no way to pass the name :(
I was hoping to address that in 1.4 by changing the layout of the import
wizard.
The user should not be asked to enter the project name upfront, only the
URL and the branch type should be provided in the first page. Then we
need to checkout the branch into a temporary folder and scan it for
existing projects. And then we can present the user with the following
options:
1) run New Project wizard or
2) create a generic project or
3) import existing projects (if there is any)
I am not sure if 2) is really needed, but I do not mind keeping it.
If 2) or 3) is selected the user should be asked to enter the project name.

>    - I shouldn't be allowed to select Bazaar project, but I
>      expect that one's hard to fix, and probably not worth it.
That is quite simple actually. Removing our wizard from new project
wizard list will do the job, the section to be removed from plugin.xml:

<extension point="org.eclipse.ui.newWizards">
<category id="org.vcs.bazaar.eclipse.ui.wizards.new"
name="%NewWizard_categoryName" />
  <wizard canFinishEarly="false"
category="org.vcs.bazaar.eclipse.ui.wizards.new"
class="org.vcs.bazaar.eclipse.ui.wizards.createproject.CreateProjectWizard"
hasPages="true" icon="icons/bzrlogo.png"
id="org.vcs.bazaar.eclipse.ui.wizards.project.CreateProjectWizard"
name="Project From Bazaar" project="true"></wizard>
</extension>

> + In my Java project, if i create a folder called target-old then
>   "compare with -> latest from branch" gives an error dialogue
>   with no message.  I wonder if this is something specific about
>   my project, and maybe not a bzr-eclipse bug.
I cannot reproduce it myself. You are not allowed to execute this action
on any unknown or added resource. The action should be disabled or in
case the action availability check is disabled in preferences you should
get a proper error message. Please take a look at eclipse log file for
any exceptions or send me a project that can be used to reproduce the
issue and I will try to investigate it further.
> + The line in the commit message editor can obscure text, perhaps
>   it should move over a pixel.  For instance, the d is hard to
>   read properly in this message:
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=17805 :)
I really doubt they are going to fix that in any foreseeable future as
they have not managed to do that for 11 years hence I added the fix to
bzr-eclipse. The line was moved 1px to the right and made
semitransparent. Branch with the fix:
lp:~piastucki/bzr-eclipse/commit-dialog-margin-painter

>   xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxd
>
> + I have a reproducible hang using bzr+ssh.  It might be
>   connected to my SSH configuration of course.  The steps are:
>
>     - Create a checkout over ssh
>     - Make local changes
>     - Make changes in remote repository also
>     - Attempt commit - which fails because workspace is not up-to-date
>     - Attempt update - hangs
I tried but could not reproduce it under Ubuntu using a branch hosted at
Launchpad.

Piotr