c2c-oerpscenario team mailing list archive

["Ferdinand @ Camptocamp" <678261@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

I am currently working on a stock_accounting module (more or less ready)

in stock/stock.py

    def _create_product_valuation_moves(self, cr, uid, move, context=None):
        """
        Generate the appropriate accounting moves if the product being moves is subject
        to real_time valuation tracking, and the source or destination location is
        a transit location or is outside of the company.
        """
        if move.product_id.valuation == 'real_time': # FIXME: product valuation should perhaps be a property?

this is very risky to leave it to users to set this at product level
no one will be able to explan the difference between stock and accounting
IMHO this is a company wide setting !?
pls think of multi-company

I think this should read 
        if move.company_id.valuation == 'real_time': 

and move the valuation field from product_product to res_company.

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
[6.0RC1] stock real-time evaluation -company settings
https://bugs.launchpad.net/bugs/678261
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: New

Bug description:
I am currently working on a stock_accounting module (more or less ready)

in stock/stock.py

    def _create_product_valuation_moves(self, cr, uid, move, context=None):
        """
        Generate the appropriate accounting moves if the product being moves is subject
        to real_time valuation tracking, and the source or destination location is
        a transit location or is outside of the company.
        """
        if move.product_id.valuation == 'real_time': # FIXME: product valuation should perhaps be a property?

this is very risky to leave it to users to set this at product level
no one will be able to explan the difference between stock and accounting
IMHO this is a company wide setting !?
pls think of multi-company

I think this should read 
        if move.company_id.valuation == 'real_time': 

and move the valuation field from product_product to res_company.