c2c-oerpscenario team mailing list archive

["vra \(openerp\)" <627670@xxxxxxxxxxxxxxxxxx>]

** Also affects: openobject-addons/5.0
   Importance: Undecided
       Status: New

** Also affects: openobject-addons/trunk
   Importance: Undecided
       Status: New

** Changed in: openobject-addons/trunk
   Importance: Undecided => Wishlist

** Changed in: openobject-addons/trunk
       Status: New => Confirmed

** Changed in: openobject-addons/trunk
     Assignee: (unassigned) => OpenERP R&D Addons Team 1 (openerp-dev-addons1)

** Changed in: openobject-addons/5.0
       Status: New => Triaged

-- 
FTP passive ports should be a range, not two separate ports
https://bugs.launchpad.net/bugs/627670
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.

Status in OpenObject Addons Modules: Confirmed
Status in OpenObject Addons 5.0 series: Triaged
Status in OpenObject Addons trunk series: Confirmed

Bug description:
In the document module, the ftp_server_passive_ports option is defined as two numbers separated by a colon. This should be interpreted as a range of port numbers, but it is interpreted as two separate numbers.

For example: if I specify ftp_server_passive_ports=5000:5003, I expect the ports 5000, 5001, 5002, and 5003 to be used. Instead, only 5000 and 5003 are used.

This is a problem because all the FTP clients I have tried open a new passive port for every request. This means that I can only make two requests before I run out of assigned passive ports, and the server starts using random ports.

The fix is really easy, just use the range function to generate a list of all the port numbers to use. The only trick is to make sure that you include the end port in the range. I'll attach a merge proposal.

I'm using OpenERP 5.0.12 on Ubuntu 10.04.