c2c-oerpscenario team mailing list archive
-
c2c-oerpscenario team
-
Mailing list archive
-
Message #11042
Re: [Bug 697395] Re: set callerid agi need different quoting
On Wednesday 05 January 2011, you wrote:
> Thanks for the bug report and the solution. I did not see this bug so
> far because I tested the new development with a softphone with which I
> was not familiar, but now I have access again to my good old IP phone.
>
> According to what I read here and my tests with my Asterisk (v1.4) and my
> IP phone : http://www.voip-info.org/wiki/view/set+callerid
> the issue is not related to the quoting, but to the fact that there
> shouldn't be any space between the name and the <phone_number>.
Come on! Asterisk 1.4 is so old! I wonder why people still use that.
> So the fix that I have made is to remove the space, but let the quoting
> unchanged.
I remember quoting issues when porting things from 1.4 to 1.6 (back then).
> By the way, I plan to make more changes to this script. I talked with
> some VoIP experts and did a number of tests with both Aastra and Thomson
> IP phones, and it seems that the conversion of the CallerID name to
> ASCII is not necessary ; UTF-8 is handled well on Asterisk, SIP and IP
> phones. So I plan to change the script and not use the conversion to
> ASCII by default ; my tests shows that it works well with non-ASCII
> caracters.
Not true. It should be configurable. Most POTS phones can only handle ascii, so
it is a device-specific thing.
In fact, it should depend on the User-Agent string of the peer registration..
( But, am I back to my old project? )
--
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/697395
Title:
set callerid agi need different quoting
Status in OpenObject Addons Modules:
New
Bug description:
We upgrade the module to the version which supports adaptation of the callerid (name, num) based upon data available in our OpenERP installation. We use asterisk 1.6 and had to change the script get_cid_name.py and replace the line:
sys.stdout.write('SET CALLERID "%s" <%s>\n' % (res_ascii, input_cid_number))
with
sys.stdout.write('SET CALLERID "%s<%s>"\n' % (res_ascii, input_cid_number))
Note the difference in the location of the quote. After that, everything works out pretty well.
Without this change the callerid (name) would be set properly, but the callerid(num) would be empty.
References