c2c-oerpscenario team mailing list archive

[xrg <xrg@xxxxxxxxx>]

Public bug reported:

This module is a nice little tool for keeping track of a developer's course. However, its current design suffers some important short-comings: Although ir.module.record is an osv.osv class (w/o columns!), it holds all data into instance memory variables (self.ids, self.recording_data). This data is held in undocumented lists, used in poorly documented functions with positional arguments (see rec[2], rec[5] etc.).
At the official version, record ids are not recreated from ir.model.data. At trunk-xrg, I tried to fix that, but the overall design suggests that it won't always work. 
One more issue is the use of 'copy' rec-data operation. When does it need to be used? IMHO, being there for one2many records etc. is not right, because it would export the same record multiple times. Do we need a way to only export the final data of a record, or would we export all temporary values, too?
Another suggestion would be to merge the logic of base_module_record with the layers of audittrail or even the temporal objects. The goal is to have only one layer of recording, and then reuse that for audit, exporting etc.

** Affects: openobject-addons
     Importance: Wishlist
         Status: Opinion

** Changed in: openobject-addons
       Status: New => Opinion

** Changed in: openobject-addons
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/780928

Title:
  base_module_record: needs redesign

Status in OpenERP Modules (addons):
  Opinion

Bug description:
  This module is a nice little tool for keeping track of a developer's course. However, its current design suffers some important short-comings: Although ir.module.record is an osv.osv class (w/o columns!), it holds all data into instance memory variables (self.ids, self.recording_data). This data is held in undocumented lists, used in poorly documented functions with positional arguments (see rec[2], rec[5] etc.).
  At the official version, record ids are not recreated from ir.model.data. At trunk-xrg, I tried to fix that, but the overall design suggests that it won't always work. 
  One more issue is the use of 'copy' rec-data operation. When does it need to be used? IMHO, being there for one2many records etc. is not right, because it would export the same record multiple times. Do we need a way to only export the final data of a record, or would we export all temporary values, too?
  Another suggestion would be to merge the logic of base_module_record with the layers of audittrail or even the temporal objects. The goal is to have only one layer of recording, and then reuse that for audit, exporting etc.