← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 620791] Re: trunk: olap indentation Error

 

You changed the indentation of pooler.get_pool... to match the elif
part.

That's plain WRONG!
You changed the workings of the code.

Please look at the original code, and what it did, in the revisions I
mentioned above and my comment #2.


Before, there was a print command in the elif part. NOTHING ELSE.
The pooler line was executed every time, together with return True, even one hierachical level up from elif.

Now it's only executed in the elif case.

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/620791

Title:
  trunk: olap indentation Error

Status in OpenERP Modules (addons):
  Fix Released

Bug description:
  Selecting bussiness intelligence on configuration wizard to be
  installed I obtain this error:

  
      import olap
    File "/home/ana/openerp6.0/server/bin/addons/olap/olap.py", line 37, in <module>
      import cube
    File "/home/ana/openerp6.0/server/bin/addons/olap/cube/__init__.py", line 3, in <module>
      from warehouse import warehouse
    File "/home/ana/openerp6.0/server/bin/addons/olap/cube/warehouse.py", line 92
       pooler.get_pool(cr.dbname).get('olap.query.logs').write(cr, uid, log_ids, {'count':counter, 'table_name': table_name})
      ^
   IndentationError: expected an indented block

  I just solved including correct indentation on line 92 of file warehouse.py, as shown below.
                      elif len(data[0]) == 3:
                          pooler.get_pool(cr.dbname).get('olap.query.logs').write(cr, uid, log_ids, {'count':counter, 'table_name': table_name})