← Back to team overview

c2c-oerpscenario team mailing list archive

Re: [Bug 782168] Re: [PS] It is possible to encode product with prices in two different currencies within the same Sales Order

 

Hi,

I am so glad you went this way to fixing it, much more sensible, enforcing
one pricelist per order.

However, there is a major bug in your code.  What if the user changed the
price manually?  You will overwrite all his manual changes.  I think you
would be better implementing this in an onchange pricelist function.

On Thu, May 19, 2011 at 11:18 PM, Ujjvala Collins (OpenERP) <uco@xxxxxxxxxxx
> wrote:

> Hello Harmel Delphine,
>
> The fix has been committed on : lp:~openerp-dev/openobject-addons/trunk-
> bug-782168-uco with revision 4715
> uco@xxxxxxxxxxx-20110519111756-hbekyz16wwzqgvse.
>
> It will be merged into main addons soon.
>
> Thanks.
>
> ** Changed in: openobject-addons
>       Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/782168
>
> Title:
>  [PS] It is possible to encode product with prices in two different
>  currencies within the same Sales Order
>
> Status in OpenERP Modules (addons):
>   Fix Committed
>
> Bug description:
>  trunk server revno 3411
>
>  having another pricelist in $ (for example)
>
>  * Sales/Sales/Sales Orders, Create a sales order using the public
> pricelist (in €)
>  * Add a sales order line, for example CPU1 (for a unit price of 75€)
>  * change the pricelist on the sales order and select the pricelist in $
>  * Add a sales order line, for example CPU1 (for a unit price of 75€
> converted into $ = 96.26$)
>  * Click on compute on the sales order line, total = 171,26
>
>  Obtained result : there is no difference between product in $ and €,
>  moreover the total just make the sum of the two prices !
>
>  Expected result : we should see that a price is in € and the other in
>  $ (add a column on the sales order line) and the total must be the sum
>  of all prices in € or all prices in $ not a mix of the two
>
>  reported by dha, OpenERP Prof Serv
>

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/782168

Title:
  [PS] It is possible to encode product with prices in two different
  currencies within the same Sales Order

Status in OpenERP Modules (addons):
  Fix Committed

Bug description:
  trunk server revno 3411

  having another pricelist in $ (for example)

  * Sales/Sales/Sales Orders, Create a sales order using the public pricelist (in €)
  * Add a sales order line, for example CPU1 (for a unit price of 75€)
  * change the pricelist on the sales order and select the pricelist in $
  * Add a sales order line, for example CPU1 (for a unit price of 75€ converted into $ = 96.26$)
  * Click on compute on the sales order line, total = 171,26

  Obtained result : there is no difference between product in $ and €,
  moreover the total just make the sum of the two prices !

  Expected result : we should see that a price is in € and the other in
  $ (add a column on the sales order line) and the total must be the sum
  of all prices in € or all prices in $ not a mix of the two

  reported by dha, OpenERP Prof Serv


References