← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 727263] Re: [6.0] diagram view (workflow) fails when labels contain non-ASCII characters or use m2o fields (e.g when showing group on wkf)

 

Hello Jacques-Etienne,

Thanks for the fix, there is a problem while merging your direct branch
to the trunk client "lp:~jba-openerp/openobject-client/trunk-
bugfix-727263" it results in almost 13 conflicts.. can you please
resolve this conflicts by merging your branch with the trunk client and
then send a merge proposal for this branch.

The server branch has no conflict issue but it would be nice if you send
a merge proposal for the same

providing a prerequisite branch as the client one.


Thanks,

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/727263

Title:
  [6.0] diagram view (workflow) fails when labels contain non-ASCII
  characters or use m2o fields (e.g when showing group on wkf)

Status in OpenERP Server:
  Confirmed

Bug description:
  Reproduce by doing one of these with GTK client:
  - change diagram view of workflow to display group_id, and notice how it fails as soon as you display a workflow diagram where a group_id is set on some transition
  - or change one of the fields values that are used as labels and put some accented text in it, such as "ééé" and see how it fails to render the diagram

  
  ------------ original desc ---------
  I suggest to put the each element of the edge label on a separate line. And in the workflow diagram view, to display the group which is a very important business info in the workflow representation.
  Merge proposal concerns:
  client/bin/widget/view/diagram_gtk/parser.py : cleaning of the ugly code. Need to be merged before server improvement
  server/bin/addons/base/ir/workflow/workflow_view.xml : display group
  server/bin/addons/base/ir/ir_ui_view.py : improve label

  Other improvement ideas are :
  - do not define transition.condition as required with default value 'True'. The condition is not required. Making it not required will prevent polluting the diagram with "True" on all transitions without conditions.
  - do not generate plenty of time the diagram when switching to diagram view, leaving it, or browsing. Generate it once, it should be enough.
  -----------------------------------


References