← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 791756] Re: unused lang_id in res_lang.py

 

Manu,

While we do want to make the code base cleaner, and you're perfectly
right about the unused variable, we would prefer you to not post such
bug report.

Processing bug reports take a lot of time. There are a lot of people
looking to bug reports. As you can see, someone (Vinay Rana in this
case) had to read through it to make sure the bug report made sense,
then assign it to the framework team. Going through my mail box, I can
see this bug report (among a lot of other reports). Again I have to read
it. Then I have to make the change (which is probably the fastest
operation, and not a problem per se). Then I have to go back to the bug
report, mark it as solved and write a little comment. And of course, you
have to fill the report in the first place.

I hope you see how much work such a simple report involves.

An alternative, if you valuate the correction, is to make a merge
proposal. There is less people looking at them, and they do not need to
be confirmed, then flagged as commited then as released with a comment.
All we have to do is to merge the proposal.

In summary, we value the cleaning of the code, but it is not worth it to
make a bug report for such a small thing.

Thanks.

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/791756

Title:
  unused lang_id in res_lang.py

Status in OpenERP Server:
  Fix Released

Bug description:
  In server v6.0.2,

  in the file bin/addons/base/res/res_lang.py

  in the class lang(osv.osv), method "install_lang" you have this line:

  lang_id = self.load_lang(cr, uid, lang)

  however lang_id is not used after the assignment.


References