← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 814620] [NEW] "if not <variable>" instead of "if <variable> is None"

 

Public bug reported:

In a lot of places (I greped "if +not +\w+:" and found tons of these)
the function definition says <variable>=None and then check if the
variable is false then creates an empty var. In python empty vars are
usually false, so if someones passes an empty var the function will
create a new one, both creating more objects than it needs to and making
it way harder to test openerp code. Changing it to if <variable> is None
is both more semantically correct and will make the problem go away.

** Affects: openobject-server
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/814620

Title:
  "if not <variable>" instead of "if <variable> is None"

Status in OpenERP Server:
  New

Bug description:
  In a lot of places (I greped "if +not +\w+:" and found tons of these)
  the function definition says <variable>=None and then check if the
  variable is false then creates an empty var. In python empty vars are
  usually false, so if someones passes an empty var the function will
  create a new one, both creating more objects than it needs to and
  making it way harder to test openerp code. Changing it to if
  <variable> is None is both more semantically correct and will make the
  problem go away.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/814620/+subscriptions


Follow ups

References