c2c-oerpscenario team mailing list archive

["Olivier Dony \(OpenERP\)" <794634@xxxxxxxxxxxxxxxxxx>]

Stéphane, Guewen,

You're right, the transition for the "new" state to the "draft" state should be allowed for any member of the "Employee" group.
Restricting it to the HR Officers causes various issues as you noticed, one of them being the creation of multiple timesheets for the same period.

This was fixed recently in trunk with revision 4892
revid:rco@xxxxxxxxxxx-20110722150620-p957g1oye9k1nss1.

I'm raising the importance to High because this can make the timesheet
system quite unusable for users that are unaware of this workflow
configuration issue. Having importance High makes it eligible for
backporting to 6.0 without an explicit OpenERP Enterprise ticket,
therefore I'm assigning it to the related team for the 6.0 branch.

Many thanks to both of you for reporting and taking the time to properly
identify the root cause of the issue!

** Changed in: openobject-addons
   Importance: Undecided => High

** Changed in: openobject-addons
       Status: Confirmed => Fix Released

** Changed in: openobject-addons
    Milestone: None => 6.1

** Summary changed:

- [6.0] Clicking on "my timesheet" always creates a duplicate timesheet for period
+ [6.0] Incorrect permissions on hr.timesheet_sheet workflow causes multiple issues for normal employees

** Description changed:

+ As described in the comments of the bug, the root issue here is the fact that the NEW->DRAFT workflow transition is restricted to the HR Officer groups, whereas it should be allowed for any Employee. In fact the second transition DRAFT->CONFIRM should also be allowed for any Employee, as it is the proper way to submit your own timesheet to your manager for approval.
+ The group restriction on these transitions should be adapted accordingly.
+ 
+ 
+ ====== original description below ====== 
+ 
  Hi,
  
  When clicking on My Timesheet menu entry, a new timesheet is created,
  even if a timesheet already exists for the current week.
  
  How to reproduce:
  - openerp 6.0 series with demo data
  - login with fbs/fbs
  - go to Human Resources / Time Tracking / My Timesheet
  - save the new timesheet
  - go to Human Resources / Time Tracking / My Timesheet agin
  - save the timesheet
  - error: Error occurred while validating the field(s) date_from,date_to: You can not have 2 timesheets that overlaps !
  Please use the menu 'My Current Timesheet' to avoid this problem.
  
  IMO, this is due to a fact that the query for existing timesheet filters
  on (state='draft'). This filter on state should be removed.
  
  Proposed patch attached.
  
  Best regards,
  
  -sbi

** Also affects: openobject-addons/6.0
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/794634

Title:
  [6.0] Incorrect permissions on hr.timesheet_sheet workflow causes
  multiple issues for normal employees

Status in OpenERP Modules (addons):
  Fix Released
Status in OpenERP Addons 6.0 series:
  Confirmed

Bug description:
  As described in the comments of the bug, the root issue here is the fact that the NEW->DRAFT workflow transition is restricted to the HR Officer groups, whereas it should be allowed for any Employee. In fact the second transition DRAFT->CONFIRM should also be allowed for any Employee, as it is the proper way to submit your own timesheet to your manager for approval.
  The group restriction on these transitions should be adapted accordingly.

  
  ====== original description below ====== 

  Hi,

  When clicking on My Timesheet menu entry, a new timesheet is created,
  even if a timesheet already exists for the current week.

  How to reproduce:
  - openerp 6.0 series with demo data
  - login with fbs/fbs
  - go to Human Resources / Time Tracking / My Timesheet
  - save the new timesheet
  - go to Human Resources / Time Tracking / My Timesheet agin
  - save the timesheet
  - error: Error occurred while validating the field(s) date_from,date_to: You can not have 2 timesheets that overlaps !
  Please use the menu 'My Current Timesheet' to avoid this problem.

  IMO, this is due to a fact that the query for existing timesheet
  filters on (state='draft'). This filter on state should be removed.

  Proposed patch attached.

  Best regards,

  -sbi

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/794634/+subscriptions