c2c-oerpscenario team mailing list archive

["Olivier Dony \(OpenERP\)" <723743@xxxxxxxxxxxxxxxxxx>]

Hello Viktor,

Your contribution is very much appreciated! The application of you patch has been delayed because we needed to perform an important refactoring: removing the copied code we had in base_vat that belonged in the vatnumber Python library.
This has just been done [1].

This also means that we don't have the check_vat_hu() function within the base_vat module, we use the one from the library.
Now, the check_vat_hu() from vatnumber doesn't support the local hungarian format either, so a patch for local hungarian format is still needed. It would be great if you could propose a new patch that wraps the call to the vatnumber library with your own logic to strip the -X-XX extension. Our code will first call self.check_vat_hu() if available, rather than the one from vatnumber, so you could implement a new check_vat_hu() that strips the local part and then forwards the rest to vatnumber.check_vat_hu() [2].

BTW, if you are a bit familiar with bzr, you could directly submit a
merge proposal to do this [3].

Thanks a lot!

[1] as of revision 5108 revid: odo@xxxxxxxxxxx-20110920121054-3oy0vm4n8idx9z03
[2] http://code.google.com/p/vatnumber/source/browse/vatnumber/__init__.py#661
[3] for more info about merge proposals, see http://doc.openerp.com/v6.0/contribute/15_guidelines/contribution_guidelines.html

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to OpenERP Project Group.
https://bugs.launchpad.net/bugs/723743

Title:
  base_vat Hungarian VAT code checking improved

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Hi,

  in Hungary the relationship b/w the local and the EU VAT formats is
  the following. If HU12345678 is the EU VAT format, then the Hungarian
  (local) VAT format is HU12345678-X-XX where X is an integer.

  I've updated the base_vat module to allow for local Hungarian format
  VAT codes too. Please merge this patch in addons.

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/723743/+subscriptions