← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 771220] Re: Incorrect active_id editable lists

 

Hello Olivier Dony,

Thanks for pointing out this issue.

It has beed fixed into the lp:~openerp-dev/openobject-
client/6.0-BUG-771220-skh branch.

Revision ID: skh@xxxxxxxxxxx-20110920132915-rlm8svg45206rgl6
Revision Number: 1896

It will be merged soon with the stable client.

Thanks

** Changed in: openobject-client/6.0
       Status: In Progress => Fix Committed

** Branch linked: lp:~openerp-dev/openobject-client/6.0-BUG-771220-skh

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to OpenERP Project Group.
https://bugs.launchpad.net/bugs/771220

Title:
  Incorrect active_id  editable lists

Status in OpenERP GTK Client:
  Fix Released
Status in OpenERP GTK Client 6.0 series:
  Fix Committed
Status in OpenERP GTK Client trunk series:
  Fix Released

Bug description:
  [Can be reproduced in 6.0 and latest trunk (rev 1879)]

  In editable lists, when you click on an action button, the active_id value passed in the context of the RPC call may sometimes be incorrect. This happens when you directly click on a button in a different line than the selected one. In that case the action is called *before* the focus changes to the line you clicked on, so it uses the previous active_id.
  This does not seem to occur in non-editable lists.
  Of course this is quite dangerous, as it can easily make you execute actions on the wrong lines, even in the wrong state.

  To reproduce:

  1. Go to an editable lists, for example Projects>Projects>Tasks (click on the Edit button to make it editable), or Warehouse>Traceability>Stock Moves.
  2. Put the focus on chosen line, and look at the ID of that record.
  3. Now, without changing the focus, directly click on an action button *of a different line*.
  4. Look at the RPC call that is executed: the active_id value is the ID of the previously selected record.
  5. Notice that the focus only goes to the line with the button you clicked *after* the RPC call.

  => It seems that the focus change should be done before calling the
  action, like it is done for non-editable lists.

  Note: After fixing this bug in trunk, I think it would be good to ask
  OPW team if they want to backport it to 6.0, as it seems like an
  important source of tricky bugs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-client/+bug/771220/+subscriptions


References