c2c-oerpscenario team mailing list archive

["Olivier Dony \(OpenERP\)" <771220@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

[Can be reproduced in 6.0 and latest trunk (rev 1879)]

In editable lists, when you click on an action button, the active_id value passed in the context of the RPC call may sometimes be incorrect. This happens when you directly click on a button in a different line than the selected one. In that case the action is called *before* the focus changes to the line you clicked on, so it uses the previous active_id.
This does not seem to occur in non-editable lists.
Of course this is quite dangerous, as it can easily make you execute actions on the wrong lines, even in the wrong state.

To reproduce:

1. Go to an editable lists, for example Projects>Projects>Tasks (click on the Edit button to make it editable), or Warehouse>Traceability>Stock Moves.
2. Put the focus on chosen line, and look at the ID of that record.
3. Now, without changing the focus, directly click on an action button *of a different line*.
4. Look at the RPC call that is executed: the active_id value is the ID of the previously selected record.
5. Notice that the focus only goes to the line with the button you clicked *after* the RPC call.

=> It seems that the focus change should be done before calling the
action, like it is done for non-editable lists.

Note: After fixing this bug in trunk, I think it would be good to ask
OPW team if they want to backport it to 6.0, as it seems like an
important source of tricky bugs.

** Affects: openobject-client
     Importance: Medium
     Assignee: OpenERP sa GTK client R&D (openerp-dev-gtk)
         Status: Confirmed

** Changed in: openobject-client
     Assignee: (unassigned) => OpenERP sa GTK client R&D (openerp-dev-gtk)

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/771220

Title:
  Incorrect active_id  editable lists

Status in OpenERP GTK Client:
  Confirmed

Bug description:
  [Can be reproduced in 6.0 and latest trunk (rev 1879)]

  In editable lists, when you click on an action button, the active_id value passed in the context of the RPC call may sometimes be incorrect. This happens when you directly click on a button in a different line than the selected one. In that case the action is called *before* the focus changes to the line you clicked on, so it uses the previous active_id.
  This does not seem to occur in non-editable lists.
  Of course this is quite dangerous, as it can easily make you execute actions on the wrong lines, even in the wrong state.

  To reproduce:

  1. Go to an editable lists, for example Projects>Projects>Tasks (click on the Edit button to make it editable), or Warehouse>Traceability>Stock Moves.
  2. Put the focus on chosen line, and look at the ID of that record.
  3. Now, without changing the focus, directly click on an action button *of a different line*.
  4. Look at the RPC call that is executed: the active_id value is the ID of the previously selected record.
  5. Notice that the focus only goes to the line with the button you clicked *after* the RPC call.

  => It seems that the focus change should be done before calling the
  action, like it is done for non-editable lists.

  Note: After fixing this bug in trunk, I think it would be good to ask
  OPW team if they want to backport it to 6.0, as it seems like an
  important source of tricky bugs.