c2c-oerpscenario team mailing list archive

[Raphaël Valyi - http://www.akretion.com <788789@xxxxxxxxxxxxxxxxxx>]

Hello Fabien,

Actually, what would be good I believe would be to extract sub methods out
of this method.
I just proposed such a patch for the sale module here:
https://code.launchpad.net/~akretion-team/openobject-addons/addons-sale-extensible-action-ship-create/+merge/76609
Please give a position on this merge. If you merge it, I have a few other
places such as here where such compaible refactoring would help us with
extension modules.


On Sun, Sep 25, 2011 at 7:53 PM, Fabien (Open ERP) <fp@xxxxxxxxxxx> wrote:

> finally, I can not apply a change, as it breaks others method.
> We keep as it fo rnow on, for compatibility issues.
>
> ** Changed in: openobject-addons
>       Status: Fix Committed => Fix Released
>
> ** Changed in: openobject-addons
>       Status: Fix Released => Invalid
>
> --
> You received this bug notification because you are a member of OpenERP
> Drivers, which is subscribed to OpenERP Addons.
> https://bugs.launchpad.net/bugs/788789
>
> Title:
>  [6.0.x][purchase] action_picking_create: broken extensibility
>
> Status in OpenERP Addons (modules):
>  Invalid
>
> Bug description:
>  Hello,
>
>  there is a design issue in purchase#action_picking_create
>  the method actually applies to a collection of purchase orders but
> actually returns only the id of the last picking that is generated.
>  To play nice efficiently with overriders, you need to change that and
> return a dictionary of all the generated pickings, just as you do in
> sale#action_ship_create
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/788789/+subscriptions
>

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to OpenERP Project Group.
https://bugs.launchpad.net/bugs/788789

Title:
  [6.0.x][purchase] action_picking_create: broken extensibility

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  Hello,

  there is a design issue in purchase#action_picking_create
  the method actually applies to a collection of purchase orders but actually returns only the id of the last picking that is generated.
  To play nice efficiently with overriders, you need to change that and return a dictionary of all the generated pickings, just as you do in sale#action_ship_create

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/788789/+subscriptions