← Back to team overview

c2c-oerpscenario team mailing list archive

[Bug 879872] [NEW] Does not check return value of pg_restore

 

Public bug reported:

Hi,

When restoring a database through the interface, the server side code
does not properly check the return value of the pg_restore process.

The process flags a non-empty stdout as error condition, but this is not
appropriate. Errors are logged to stderr by pg_restore, as are warnings.
Neither are of any use. The process should call wait() on the Popen
object, and check on its return value which is the return value of
pg_restore.

Reproducable on trunk, rev 3772.

Cheers,
Stefan.

** Affects: openobject-server
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to OpenERP Project Group.
https://bugs.launchpad.net/bugs/879872

Title:
  Does not check return value of pg_restore

Status in OpenERP Server:
  New

Bug description:
  Hi,

  When restoring a database through the interface, the server side code
  does not properly check the return value of the pg_restore process.

  The process flags a non-empty stdout as error condition, but this is
  not appropriate. Errors are logged to stderr by pg_restore, as are
  warnings. Neither are of any use. The process should call wait() on
  the Popen object, and check on its return value which is the return
  value of pg_restore.

  Reproducable on trunk, rev 3772.

  Cheers,
  Stefan.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/879872/+subscriptions


Follow ups

References