c2c-oerpscenario team mailing list archive

[Numérigraphe <870090@xxxxxxxxxxxxxxxxxx>]

>From my humble point of view, the biggest problems now are in do_partial() in both stock picking and stock move :
1/ there is a lot of duplicate code
2/ it does both stock operations and average price computations - separation of concern would help a lot here. I know nothing about prices
3/ it's not clear to me how the two do_partial()'s are supposed to be used by the rest of the system
When those are solved, the code would be easier to adapt and then we could help improve the process  and the UI.
Lionel Sausin.

** Description changed:

- I would love to make a patch for the trunk for a simple improvement in the partial picking procedure (https://bugs.launchpad.net/openobject-addons/+bug/553112).
+ I would love to make a patch for the trunk for a simple improvement in the partial picking procedure (https://bugs.launchpad.net/openobject-addons/+bug/891664).
  In v5, it used to be a pretty straigtforward patch in a rather straightforward old-style wizard.
- in V6, some crazy form of refactoring has been made, and the # FIXMEs admit that this was badly made.
- Now the whole thing in unreadable and absurd, with duplicate code and useless database writes.
- Can someone please clean this mess ?
+ in V6, some form of refactoring has been made, but the # FIXMEs admit that this was not made right.
+ Now the whole thing in unreadable, and it makes it hard for the community to contribute improvements.

** Description changed:

  I would love to make a patch for the trunk for a simple improvement in the partial picking procedure (https://bugs.launchpad.net/openobject-addons/+bug/891664).
- In v5, it used to be a pretty straigtforward patch in a rather straightforward old-style wizard.
+ In v5, it used to be a straigtforward patch in an old-style wizard.
  in V6, some form of refactoring has been made, but the # FIXMEs admit that this was not made right.
  Now the whole thing in unreadable, and it makes it hard for the community to contribute improvements.

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to OpenERP Project Group.
https://bugs.launchpad.net/bugs/870090

Title:
  More refactoring needed for partial pickings

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  I would love to make a patch for the trunk for a simple improvement in the partial picking procedure (https://bugs.launchpad.net/openobject-addons/+bug/891664).
  In v5, it used to be a straigtforward patch in an old-style wizard.
  in V6, some form of refactoring has been made, but the # FIXMEs admit that this was not made right.
  Now the whole thing in unreadable, and it makes it hard for the community to contribute improvements.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/870090/+subscriptions