calibre-devs team mailing list archive

[Kovid Goyal <kovid@xxxxxxxxxxxxxx>]

The launchpad merge request never reached me. 

Logging via print is fine, as long as you make sure to convert unicode 
characters properly (that's what the logging framework in claibre does). In 
Python 2.5 you have to encode all unicode strings in preferred_encoding In 
Python 2.6 you have to decode all byte strings to unicode. You can use 
LoggingInterface to do this automatically for you, or just write a simple 
wrapper around print.

There are no package relative imports mainly because some of the freezing 
programs used to generate binaries on various platforms have had various 
problems with dependency calculation, so I decided to keep things as simple 
(from a machine perspective) as possible.

I'll merge your code over the next few days.

Kovid.

On Friday 12 December 2008 18:59:07 Marshall T. Vandegrift wrote:
> Well, with a few caveats.  I used launchpad to do a merge request, but I
> don't know if that resulted in you seeing anything or not, Kovid.  And as
> the revison log indicates, it was a few commits premature anyway.
>
> I've reaplaced the ctypes LZX compressor with a Python/C type, cleaned up
> the license strings etc, implemented setting the various cover-image
> metadata properties, and had a file tested on the Windows Mobile version of
> MSReader.  W00t.
>
> Outstanding issues:
>
>   - Still no anchor hashing, so only 6 anchors per file or links into that
> file don't work.
>   - No CSS/markup transformation to the subset MSReader groks.
>   - Logging is via the 'print' statement. Should that be using the logging
> system I saw in some other parts of calibre?
>   - Not so much yet in the way of error-handling/-recover.  Arcane stack
> traces for everyone!
>   - Is there any reason calibre doesn't use package-relative module
> imports? That would allow e.g. calibre.ebooks.lit to provide LitReader and
> LitWriter, hiding the underlying mess.
>
> That's all I can think of for now.
>
> Fish,
>
> -Marshall
>
>
> !DSPAM:3,4943250375721636283973!

-- 
_____________________________________

Kovid Goyal  MC 452-48
California Institute of Technology
1200 E California Blvd
Pasadena, CA 91125

cell  : +01 626 390 8699
office: +01 626 395 6595 (449 Lauritsen)
email : kovid@xxxxxxxxxxxxxxxxxx
web   : http://www.kovidgoyal.net
_____________________________________