← Back to team overview

calibre-devs team mailing list archive

Re: Hanlin V5

 

As there are rather a lot of clones that use the Hanlin drivers, I'd rather not change their swapping semantics. Instead I've committed a fix for your in rev 9156

Kovid.

On Sat, May 07, 2011 at 02:34:29AM +0900, Joel wrote:
> Hello,
> 
> I have been having problems) with the Hanlin V5 driver. I have a BeBook
> Mini. I was getting DeviceErrors and traced it to the device main memory
> being returned as None. main should have been "/dev/sdc" and carda
> should have been None, but they were switched.
> 
> Below I will refer to classes in src/calibre/devices/hanlin/driver.py.
> 
> The HANLINV3 class contains a linux_swap_drives (and
> windows_sort_drives) that changes the order of the drives. HANLINV5
> inherits this, but actually needs a do-nothing linux_swap_drives (and
> windows_sort_drives, I suppose). I notice that the BOOX class also
> overrides HANLINV3 with do-nothing methods.
> 
> I added the do-nothing methods to a branch on LP,
> lp:~joelkoerwer/calibre/jfk-trunk.
> 
> I also added chm and djvu to the list of Hanlin V5 formats, though it
> supports many others that are still not listed.
> 
> Questions:
> Can anyone confirm or contradict that the HANLINV5 needs to override the
> HANLINV3 behavior?
> Can anyone confirm that the HANLINV3 needs the reordering?
> 
> Thanks,
> Joel
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~calibre-devs
> Post to     : calibre-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~calibre-devs
> More help   : https://help.launchpad.net/ListHelp
> 
> !DSPAM:3,4dc436c460451337913573!
> 
> 

-- 
_____________________________________

Dr. Kovid Goyal 
http://www.kovidgoyal.net
http://calibre-ebook.com
_____________________________________

Attachment: pgpd0zwVwzm9R.pgp
Description: PGP signature


Follow ups

References