canonical-ubuntu-qa team mailing list archive

[Paride Legovini <mp+443597@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

I think there are too many changes in this MP:

- retry code
- dry-run implementation
- fake-release implementation
- switch from print() logging to logging module
- move code into a main() function
- unrelated linting changes?

Ideally these should be split in separate, easier to review MPs.

Our main aim here is figuring out why seed-new-release sometimes gets stuck; the retry logic it already has triggers, but it is not enough to make it resume copying results.

So my suggestion is: implement --dry-run (only that). It should only disable swift writes, the leaving the rest of the logic as is. Let's see if we can reproduce the failure in this way.

If you want to do preparatory work (e.g. moving code to main()) that's fine, but make it a separate MP that we'll land first.
-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/443597
Your team Canonical's Ubuntu QA is subscribed to branch autopkgtest-cloud:master.