canonical-ubuntu-qa team mailing list archive

[Brian Murray <mp+452474@xxxxxxxxxxxxxxxxxx>]

Brian Murray has proposed merging autopkgtest-cloud:no-test-containers into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/452474

I was looking at our swift containers and noticed that there were a couple which were test runs from seed-new-release e.g. martian and mystical.

autopkgtest-mantic-zhsj-dhcpcd5
autopkgtest-martian
autopkgtest-mystical
autopkgtest-trusty

seed-new-release should not create these containers when run in --dry-run mode.
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of autopkgtest-cloud:no-test-containers into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release
index 41e684e..77f155a 100755
--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release
+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/seed-new-release
@@ -138,10 +138,11 @@ target_container = container_prefix + args.new_release
 if args.test_container:
     target_container = "test-" + target_container
 
-# create new container
-swift_con.put_container(
-    target_container, headers={"X-Container-Read": ".rlistings,.r:*"}
-)
+if not args.dry_run:
+    # create new container
+    swift_con.put_container(
+        target_container, headers={"X-Container-Read": ".rlistings,.r:*"}
+    )
 
 # read existing names (needs multiple batches)
 existing = set()