canonical-ubuntu-qa team mailing list archive

[Brian Murray <mp+452475@xxxxxxxxxxxxxxxxxx>]

Brian Murray has proposed merging autopkgtest-cloud:download-results-notes into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/452475

I thought the comment would be more helpful if we were to explicitly state what a container for PPA results looks like.
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of autopkgtest-cloud:download-results-notes into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-web/webcontrol/download-results b/charms/focal/autopkgtest-web/webcontrol/download-results
index 0f14155..d97b98a 100755
--- a/charms/focal/autopkgtest-web/webcontrol/download-results
+++ b/charms/focal/autopkgtest-web/webcontrol/download-results
@@ -58,7 +58,8 @@ def process_message(msg, db_con):
     version = info["testpkg_version"]
     (_, _, _, _, run_id) = info["swift_dir"].split("/")
 
-    # we don't handle PPA requests
+    # we don't handle PPA requests and their container names are
+    # formatted like autopkgtest-$release-$user-$ppaname
     if container != ("autopkgtest-{}".format(release)):
         logging.debug("Ignoring non-distro request: {}".format(info))
         msg.channel.basic_ack(msg.delivery_tag)