canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+452531@xxxxxxxxxxxxxxxxxx>]

Tim Andersson has proposed merging ~andersson123/autopkgtest-cloud:migration_reference_0_all_proposed into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/452531
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:migration_reference_0_all_proposed into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
index ea22329..99742d7 100644
--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
@@ -83,6 +83,16 @@ class Submit:
         assert self.amqp_creds.scheme == "amqp"
         logging.debug("AMQP credentials: %s" % repr(self.amqp_creds))
 
+    def migration_reference_all_proposed_check(self, triggers, kwargs):
+        if (
+            "migration-reference/0" in triggers
+            and "all-proposed" in kwargs.keys()
+            and kwargs["all-proposed"] == 1
+        ):
+            raise BadRequest(
+                "migration-reference/0 and all-proposed=1 are not compatible arguments."
+            )
+
     # pylint: disable=dangerous-default-value
     def validate_distro_request(
         self, release, arch, package, triggers, requester, ppas=[], **kwargs
@@ -99,6 +109,8 @@ class Submit:
         """
         self.is_request_queued_or_running(release, arch, package, triggers)
 
+        self.migration_reference_all_proposed_check(triggers, kwargs)
+
         can_upload_any_trigger = False
 
         try: