canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+458950@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
> index 3744f06..ef2ca83 100755
> --- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
> +++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
> @@ -322,7 +323,7 @@ def request_matches_per_package(package, arch, release, s):
>  
>  
>  def process_output_dir(
> -    dir, pkgname, code, triggers, additional_params: dict = None
> +    dir, pkgname, code, triggers, test_uuid, additional_params: dict = None,

Worth typing the test_uuid param maybe?

>  ):
>      """Post-process output directory"""
>  
> @@ -1037,6 +1048,7 @@ def request(msg):
>              argv.append("--testname=%s" % params["testname"])
>  
>          argv.append("--")
> +        # Need to bake the UUID into these args! I think maybe the server-name

Comment can be dropped.

>          argv += subst(
>              cfg.get("virt", "args"),
>              big_pkg,
> diff --git a/charms/focal/autopkgtest-web/webcontrol/browse.cgi b/charms/focal/autopkgtest-web/webcontrol/browse.cgi
> index 4772be2..f39b30f 100755
> --- a/charms/focal/autopkgtest-web/webcontrol/browse.cgi
> +++ b/charms/focal/autopkgtest-web/webcontrol/browse.cgi
> @@ -339,6 +339,7 @@ def package_release_arch(package, release, arch, _=None):
>                  url,
>                  show_retry,
>                  all_proposed,
> +                row[7],

default for column is "" so this shouldn't be problematic

>              )
>          )
>  


-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/458950
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:uuid-integration into autopkgtest-cloud:master.