canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+462439@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> index 4633614..d2e5b0d 100644
> --- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> +++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> @@ -350,6 +350,7 @@ class Submit:
>                      amqp.Message(body, delivery_mode=2),  # persistent
>                      routing_key=queue,
>                  )
> +        return params["uuid"]

it's difficult because params is passed like **params so the values in params which are required for the HTML when returned are taken out of the params dict in the function and become named variables :/ I agree though it kinda sucks

>  
>      @classmethod
>      def post_json(cls, url, data, auth_file, project):


-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/462439
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:return-uuid-upon-test-request into autopkgtest-cloud:master.