canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+465935@xxxxxxxxxxxxxxxxxx>]

I'm not a whizz with sql, but I'll give this a review anyway :)

Everything looks sensible, I have one inline question.

Another question - does the latest commit obsolete the `./branch_series.sh` script on the isotracker environment?

If so, this requires an MP for the jira templates to go along with this change, right? I can make this MP if you'd like.

Diff comments:

> diff --git a/scripts/branch-series.sql b/scripts/branch-series.sql
> index 17e4b58..5aafbfc 100644
> --- a/scripts/branch-series.sql
> +++ b/scripts/branch-series.sql
> @@ -19,8 +19,17 @@ INSERT INTO qatracker_milestone (seriesid, siteid, title, notify, status,
>                                   autofill)
>  	SELECT id, 1, INITCAP(:NEWSERIES) || ' Daily', 0, 0, 0
>  	FROM qatracker_milestone_series WHERE title=INITCAP(:NEWSERIES);
> --- correct for the common non-LTS case; make the calling script know the
> --- difference
> -UPDATE qatracker_milestone SET status=1 WHERE title=INITCAP(:OLDSERIES) || ' Daily';
> +UPDATE qatracker_milestone SET status=1
> +WHERE title=INITCAP(:OLDSERIES) || ' Daily' AND :LTS=0;
> +INSERT INTO qatracker_product_download
> +		(productid, seriesid, filename, path, type)
> +	SELECT DISTINCT d.productid, s.id, d.filename,
> +		REPLACE(d.path,'/d','/SERIES/d'), d.type
> +	FROM qatracker_milestone_series s
> +	LEFT JOIN qatracker_milestone_series_manifest m ON s.id=m.seriesid
> +	LEFT JOIN qatracker_product p ON m.productid=p.id
> +	LEFT JOIN qatracker_product_download d ON p.id=d.productid
> +	WHERE s.title='Noble' AND d.seriesid IS NULL

Should this be hardcoded to 'Noble'? Do we need to update this periodically? Should this be the latest LTS?

> +		AND d.productid IS NOT NULL AND :LTS=1;
>  DROP TABLE nextid;
>  COMMIT;


-- 
https://code.launchpad.net/~ubuntu-qa-website-devel/ubuntu-qa-website/+git/ubuntu-qa-website/+merge/465935
Your team Ubuntu QA Website Developers is requested to review the proposed merge of ubuntu-qa-website:branch-series-lts into ubuntu-qa-website:main.