canonical-ubuntu-qa team mailing list archive

Thread
Date

Re: [Merge] ~uralt/autopkgtest-cloud:allowed-user-cache into autopkgtest-cloud:master

To: mp+470495@xxxxxxxxxxxxxxxxxx
From: Skia <mp+470495@xxxxxxxxxxxxxxxxxx>
Date: Thu, 01 Aug 2024 19:21:35 -0000
In-reply-to: <172252289522.2776199.82659832780046148.launchpad@scripts.lp.internal>
Reply-to: mp+470495@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Needs Fixing

While I don't think I have any particular issue with the code itself, I think there is a design issue, because the script is called with the apache CGI module, which isn't a long-lasting process, meaning the in-memory dict will not remain through the various calls. I suggest writing and loading that dict in a json file somewhere in `/dev/shm`, that way you'll be able to share it even between various parallel requests. Be careful to update the file atomically though, with something like a move from a temporary write file.
-- 
https://code.launchpad.net/~uralt/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/470495
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~uralt/autopkgtest-cloud:allowed-user-cache into autopkgtest-cloud:master.