cf-charmers team mailing list archive

Thread
Date

Re: Refactored to use refactored charm-helpers (issue 94500044)

To: Cory Johns <cory.johns@xxxxxxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Mon, 19 May 2014 19:00:53 -0000
In-reply-to: <20140516230700.5910.85066.launchpad@ackee.canonical.com>
Reply-to: mp+219916@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

LGTM +1


https://codereview.appspot.com/94500044/diff/1/hooks/hooks.py
File hooks/hooks.py (left):

https://codereview.appspot.com/94500044/diff/1/hooks/hooks.py#oldcode18
hooks/hooks.py:18: fileproperties = {'owner': 'vcap'}
Do we care about the mode here as well?

https://codereview.appspot.com/94500044/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-logrouter/refactor/+merge/219916
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-logrouter/refactor into lp:~cf-charmers/charms/trusty/cf-logrouter/trunk.

References

[Merge] lp:~johnsca/charms/trusty/cf-logrouter/refactor into lp:~cf-charmers/charms/trusty/cf-logrouter/trunk
From: Cory Johns, 2014-05-16