cf-charmers team mailing list archive
-
cf-charmers team
-
Mailing list archive
-
Message #00196
Re: Refactored to use refactored charm-helpers (issue 91510047)
LGTM +1
Thanks again
https://codereview.appspot.com/91510047/diff/1/hooks/hooks.py
File hooks/hooks.py (right):
https://codereview.appspot.com/91510047/diff/1/hooks/hooks.py#newcode11
hooks/hooks.py:11: import config as lg_config
just config? or we could rename to common as in some of the others now.
https://codereview.appspot.com/91510047/
--
https://code.launchpad.net/~johnsca/charms/trusty/cf-loggregator/refactor/+merge/219915
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-loggregator/refactor into lp:~cf-charmers/charms/trusty/cf-loggregator/trunk.
References