← Back to team overview

cf-charmers team mailing list archive

Re: Refactored to use refactored charm-helpers (issue 91510047)

 

https://codereview.appspot.com/91510047/diff/1/hooks/hooks.py
File hooks/hooks.py (right):

https://codereview.appspot.com/91510047/diff/1/hooks/hooks.py#newcode11
hooks/hooks.py:11: import config as lg_config
On 2014/05/19 18:58:39, benjamin.saller wrote:
> just config? or we could rename to common as in some of the others
now.

I was using xx_config to prevent potential conflicts with
hookenv.config, but those are all referenced indirectly anyway, so it's
probably not worth bothering with the prefix.

https://codereview.appspot.com/91510047/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-loggregator/refactor/+merge/219915
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-loggregator/refactor into lp:~cf-charmers/charms/trusty/cf-loggregator/trunk.


References