cf-charmers team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

LGTM, thanks for this.

just some trivial notes. I appreciate how we are getting by with less
and less code in the charms as helpers evolve.

Didn't verify this is working, back to the CI system :)


https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py
File hooks/hooks.py (right):

https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py#newcode12
hooks/hooks.py:12: from path import path
this could be added to the requirements rather than included directly,
but I guess its ok

https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py#newcode80
hooks/hooks.py:80:
I'm fine with this for now, but we need to settle on one pattern moving
forward, this is slightly different from cory's spelling. we should know
the spelling answers on Tuesday though as discussed.

https://codereview.appspot.com/99470044/

-- 
https://code.launchpad.net/~whitmo/charms/trusty/cf-uaa/require-mysql/+merge/220839
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~whitmo/charms/trusty/cf-uaa/require-mysql into lp:~cf-charmers/charms/trusty/cf-uaa/trunk.