cf-charmers team mailing list archive

[Whit Morriss <whit.morriss@xxxxxxxxxxxxx>]

ack.


https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py
File hooks/hooks.py (right):

https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py#newcode12
hooks/hooks.py:12: from path import path
On 2014/05/23 18:26:32, benjamin.saller wrote:
> this could be added to the requirements rather than included directly,
but I
> guess its ok

we could make a deb for path.py (or is there a way of defining pip
installable requirements that I have missed?).  I'd lobby we actually
include it as part of charm-helpers as it cleans up a wide variety of
common fs operations and offers a single point for mocking or patching
for test purposes.

https://codereview.appspot.com/99470044/

-- 
https://code.launchpad.net/~whitmo/charms/trusty/cf-uaa/require-mysql/+merge/220839
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~whitmo/charms/trusty/cf-uaa/require-mysql into lp:~cf-charmers/charms/trusty/cf-uaa/trunk.