← Back to team overview

cf-charmers team mailing list archive

Re: [Juju Deployer]: Tagging branch inside bundle file doesn't impact on what revision of charm is fetched.

 

Thank you so much, Kapil.


On 26 May 2014 19:14, Kapil Thangavelu <kapil.thangavelu@xxxxxxxxxxxxx>wrote:

> Got response via private email, replying to the list.
>
> The deployer version your using (0.3.6) only updates vcs trees to
> revisions or tags when initially fetching them or when explicitly told to
> update via the -u flag. So if your doing vcs management outside of
> deployer, then you would need to pass -u flag to have it do vcs management
> on the branches. This behavior has been changed in the current release
>  .0.3.8  so that pinned revisions are always checked/ensured prior to
> deployment even without the -u flag. The 0.3.8 release is available on
> pypi, via pip install juju-deployer (i'd recommend removing the pkg first
> if your going down this road or using a virtualenv) its also in the daily
> ppa (https://launchpad.net/~ahasenack/+archive/juju-deployer-daily)
>
> cheers,
>
> Kapil
>
>
>
> On Mon, May 26, 2014 at 11:34 AM, Kapil Thangavelu <
> kapil.thangavelu@xxxxxxxxxxxxx> wrote:
>
>> what commands are you using to run deployer?
>>
>>
>> On Mon, May 26, 2014 at 9:55 AM, Alexander Lomov <lomov.as@xxxxxxxxx>wrote:
>>
>>> Thank you for answering
>>>
>>> This command still shows the problem:
>>>
>>> lomov:~/work/launchpad/bundle/trusty/cf-cloud-controller → bzr revno
>>> --tree
>>> 28
>>>
>>> I expected to get 26 as an output.
>>>
>>>
>>> On 26 May 2014 16:15, Kapil Thangavelu <kapil.thangavelu@xxxxxxxxxxxxx>wrote:
>>>
>>>> your methodology in the gist is flawed, log will always show the full
>>>> history. if you want to know the revision of the working copy use $  bzr
>>>> revno --tree
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Mon, May 26, 2014 at 8:26 AM, Alexander Lomov <lomov.as@xxxxxxxxx>wrote:
>>>>
>>>>> Hello, Kapil.
>>>>>
>>>>> We've noticed that juju-deployer fetches last revisions for branches
>>>>> that are listed in bundle.yaml file without looking if tags are set.
>>>>>
>>>>> For instance, I want to reference to @last_good (which is set to
>>>>> revision 26) tag of cloud-controller charm, after I run bundle deployer
>>>>> command I see the latest revision inside trusty/cf-cloud-controller folder.
>>>>> If I understand it right it has to fetch revision 26. Changes are applied
>>>>> only after changing cf-cloud-controller repo manually.
>>>>>
>>>>> You can find details in this gist:
>>>>> https://gist.github.com/allomov/dbc9154d6d5a432eefda
>>>>>
>>>>>
>>>>> Thank you,
>>>>> Alex.
>>>>>
>>>>
>>>>
>>>
>>
>

References