cf-charmers team mailing list archive

Thread
Date

Re: Refactor to callback services API (issue 104720044)

To: Cory Johns <cory.johns@xxxxxxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Thu, 29 May 2014 18:54:14 -0000
In-reply-to: <20140529182900.8140.5786.launchpad@ackee.canonical.com>
Reply-to: mp+221443@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

LGTM, thanks


https://codereview.appspot.com/104720044/diff/1/hooks/config.py
File hooks/config.py (right):

https://codereview.appspot.com/104720044/diff/1/hooks/config.py#newcode23
hooks/config.py:23: result = subprocess.check_output(['dig', '+short',
'@8.8.8.8', address])
thank you google, there should be a better way, but I've done this too

https://codereview.appspot.com/104720044/diff/1/hooks/config.py#newcode38
hooks/config.py:38: 'ports': [80, 443],
we still expose 443 but its aspirational iirc

https://codereview.appspot.com/104720044/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-go-router/services-callback-fu/+merge/221443
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-go-router/services-callback-fu into lp:~cf-charmers/charms/trusty/cf-go-router/trunk.

References

[Merge] lp:~johnsca/charms/trusty/cf-go-router/services-callback-fu into lp:~cf-charmers/charms/trusty/cf-go-router/trunk
From: Cory Johns, 2014-05-29