cf-charmers team mailing list archive

Thread
Date

Re: Refactor to callback services API (issue 101960043)

To: Cory Johns <cory.johns@xxxxxxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Thu, 29 May 2014 18:54:15 -0000
In-reply-to: <20140529182832.8146.49908.launchpad@ackee.canonical.com>
Reply-to: mp+221442@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

LGTM



https://codereview.appspot.com/101960043/diff/1/hooks/install
File hooks/install (right):

https://codereview.appspot.com/101960043/diff/1/hooks/install#newcode49
hooks/install:49: return 'linux-image-extra-{}'.format(kernel_release)
thanks again for including this

https://codereview.appspot.com/101960043/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-dea/services-callback-fu/+merge/221442
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-dea/services-callback-fu into lp:~cf-charmers/charms/trusty/cf-dea/trunk.

References

[Merge] lp:~johnsca/charms/trusty/cf-dea/services-callback-fu into lp:~cf-charmers/charms/trusty/cf-dea/trunk
From: Cory Johns, 2014-05-29