cf-charmers team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

LGTM

wondering if we want to formalize the relation-set but all good


https://codereview.appspot.com/105880043/diff/20001/hooks/config.py
File hooks/config.py (right):

https://codereview.appspot.com/105880043/diff/20001/hooks/config.py#newcode21
hooks/config.py:21: {'shared_secret': host.pwgen(20)}
nice

https://codereview.appspot.com/105880043/diff/20001/hooks/logrouter-relation-changed
File hooks/logrouter-relation-changed (right):

https://codereview.appspot.com/105880043/diff/20001/hooks/logrouter-relation-changed#newcode5
hooks/logrouter-relation-changed:5: config.send_relation_settings()
interesting, I'd have expected this to be a callback in the service decl
(but usually not a data-ready, something else).

https://codereview.appspot.com/105880043/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-logrouter/port-conflicts/+merge/222676
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-logrouter/port-conflicts into lp:~cf-charmers/charms/trusty/cf-logrouter/trunk.