cf-charmers team mailing list archive

[Cory Johns <cory.johns@xxxxxxxxxxxxx>]

On 2014/06/11 22:31:19, benjamin.saller wrote:
> hooks/logrouter-relation-changed:5: config.send_relation_settings()
> interesting, I'd have expected this to be a callback in the service
decl (but
> usually not a data-ready, something else).

I played around with having that as a callback (in data-ready) but it
introduced deadlocks since it wasn't sending out the relation settings
that other services were waiting on.  As for formalizing sending
relation data to a callback (or something) other than data-ready, it
seems like a good idea, but I'm not sure what form it should take.  The
conditions on which a charm would want to send relation data seem to be
limited to: 1) a relation or config hook is called (e.g., it's static or
config data that doesn't depend on another service), or 2) data-ready
(e.g., it requires the entirety of the config to be known or the service
to be up to be at all meaningful, yet it won't block other services that
we depend on, creating a deadlock).

We can always add to the spec later, once we have more data points on
exactly how it will be used and can concretely identify the repetitive
bits.

https://codereview.appspot.com/105880043/

-- 
https://code.launchpad.net/~johnsca/charms/trusty/cf-logrouter/port-conflicts/+merge/222676
Your team Cloud Foundry Charmers is requested to review the proposed merge of lp:~johnsca/charms/trusty/cf-logrouter/port-conflicts into lp:~cf-charmers/charms/trusty/cf-logrouter/trunk.