checkbox-dev team mailing list archive

[Zygmunt Krynicki <zygmunt.krynicki@xxxxxxxxxxxxx>]

I still think that the basic idea of using dependencies on this is
*wrong*. We should have a test for touchscreen that depends on one
having a touchscreen hardware. If we cannot detect this reliably
automatically we should just ask and provide an appropriate resource
record in response.

On Fri, Mar 13, 2015 at 3:34 AM, Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx> wrote:
> Done, it's here:
> https://code.launchpad.net/~cypressyew/checkbox/fix-desc-touchscreen-job/+merge/252850
> It's lucky that we found this mistake :D
> Thanks
>
> On Fri, Mar 13, 2015 at 1:57 AM, Ara Pulido <ara.pulido@xxxxxxxxxxxxx> wrote:
>>
>>
>> On 12/03/15 15:00, Zygmunt Krynicki wrote:
>>> This merge requests [1] makes me realize we should have support for
>>> interactive resource jobs. It's much less of a hack than using
>>> dependencies and failing remaining jobs.
>>>
>>>
>>> [1] https://code.launchpad.net/~cypressyew/checkbox/fix-desc-touchscreen-job/+merge/252683
>>
>> This is the incorrect fix for this, but I didn't arrive soon enough to
>> comment on the merge request.
>>
>> We have these two tests:
>>
>>  - touchscreen/nontouch-automated - detects automatically if a display
>> is NOT touch
>>  - touchscreen/multitouch-automated - detects automatically if it is touch
>>
>> The rest of touch tests are based on multitouch-automated (the positive
>> one), except touchscreen/multitouch-manual, the depends on the nontouch
>> one, basically to make sure that the screen is actually non touch (and
>> not a problem with the driver).
>>
>> So the multitouch-manual test should say something like:
>>
>> "Your screen was detected as a non touch screen. Is this correct?"
>>
>> So, if it was actually a touch one we fail the test, and not the other
>> way round.
>>
>> Po-Hsu, can you propose another merge along those lines, please?
>>
>> Thanks!
>> Ara.
>>
>>>
>>
>> --
>> Mailing list: https://launchpad.net/~checkbox-dev
>> Post to     : checkbox-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~checkbox-dev
>> More help   : https://help.launchpad.net/ListHelp
>
> --
> Mailing list: https://launchpad.net/~checkbox-dev
> Post to     : checkbox-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~checkbox-dev
> More help   : https://help.launchpad.net/ListHelp