← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] lp:~gholms/cloud-init/hostname-refactor into lp:cloud-init


What do u think about the following.

Look at https://code.launchpad.net/~harlowja/cloud-init/resolv-conf-niceness/+merge/125578

There is now little helper classes in distros that can read/write/update /etc/hosts and /etc/resolv.conf and provide useful setters/getters/adders and the such, do u think this /etc/hostname code belongs in such a helper class instead of putting the logic to understand the /etc/hostname format in the parent class. That might make testing easier (u can individually test the helper class) and then the main distro class just uses that helper class to add/delete/... while letting the helper do the actual logic/format understanding...
Your team cloud init development team is requested to review the proposed merge of lp:~gholms/cloud-init/hostname-refactor into lp:cloud-init.