← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] lp:~gpadgett/cloud-init/ovirt into lp:cloud-init

 

this looks fine to me, the only question i have is over 'blkid' usage and /dev/sr0.
I have one concern. At one point I was just trying 'mount /dev/sr0' and expecting that to time out quickly, but it turned out that that was taking 18 seconds to time out in a VM with an empty cd-rom. (see revision 350).
   I just want to make sure that we're not going todo something similar here.  I suspect not, but would like to make sure that you've verified that boot speed is not affected significantly by this.


Reguarding the systemd changes, I largely have to blindly trust you.
Maybe Josh can sanity check?

-- 
https://code.launchpad.net/~gpadgett/cloud-init/ovirt/+merge/155634
Your team cloud init development team is requested to review the proposed merge of lp:~gpadgett/cloud-init/ovirt into lp:cloud-init.


References