← Back to team overview

cloud-init-dev team mailing list archive

[Merge] lp:~pquerna/cloud-init/allow-configdrive-in-partitions into lp:cloud-init

 

Paul Querna has proposed merging lp:~pquerna/cloud-init/allow-configdrive-in-partitions into lp:cloud-init.

Requested reviews:
  cloud init development team (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~pquerna/cloud-init/allow-configdrive-in-partitions/+merge/200607

This change removes the filtering of partitions from potential ConfigDrive sources.

In the case of a bare metal device, it may not have a dedicated separate device for ConfigDrive, but instead have a ConfigDrive available on a partition.

The function `read_config_drive_dir_v2` already has filters in place to eliminate devices that don't have the required files.
-- 
https://code.launchpad.net/~pquerna/cloud-init/allow-configdrive-in-partitions/+merge/200607
Your team cloud init development team is requested to review the proposed merge of lp:~pquerna/cloud-init/allow-configdrive-in-partitions into lp:cloud-init.
=== modified file 'cloudinit/sources/DataSourceConfigDrive.py'
--- cloudinit/sources/DataSourceConfigDrive.py	2013-09-04 06:51:51 +0000
+++ cloudinit/sources/DataSourceConfigDrive.py	2014-01-06 23:08:32 +0000
@@ -284,9 +284,6 @@
     # followed by fstype items, but with dupes removed
     combined = (by_label + [d for d in by_fstype if d not in by_label])
 
-    # We are looking for block device (sda, not sda1), ignore partitions
-    combined = [d for d in combined if not util.is_partition(d)]
-
     return combined
 
 


Follow ups